Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use strings.Cut, also strings.IndexByte more #432

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

serprex
Copy link
Member

@serprex serprex commented Oct 13, 2024

strings.Cut was added in 1.18: golang/go#46336

@serprex
Copy link
Member Author

serprex commented Oct 13, 2024

There's a Split on message in cht which could instead use IndexLastByte to only slice last element, but out of these it's the hairiest change so I let it be

@serprex serprex requested review from ernado and genzgd October 13, 2024 01:32
@jkaflik jkaflik merged commit ea7df0e into main Oct 16, 2024
25 checks passed
@jkaflik jkaflik deleted the strings-cut branch October 16, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants